The big change here is setting a default TTL on Sidekiq Unique Job locks. The default is nil which means a lock will live f o r e v e r and if the lock fails to clear for some reason then the job is locked until redis crashes or somebody comes along and manually clears them. This sets the default to 1 day which seems mostly reasonable and can be overridden in specific workers if needed.
The other piece of the PR is setting a TTL and a custom prefix so I can try and hunt down locks for maintenance stats specifically in the future.
The big change here is setting a default TTL on Sidekiq Unique Job locks. The default is
nilwhich means a lock will live f o r e v e r and if the lock fails to clear for some reason then the job is locked until redis crashes or somebody comes along and manually clears them. This sets the default to 1 day which seems mostly reasonable and can be overridden in specific workers if needed.The other piece of the PR is setting a TTL and a custom prefix so I can try and hunt down locks for maintenance stats specifically in the future.