search

librasn / rasn

A Safe #[no_std] ASN.1 Codec Framework
Other
183 stars 43 forks source link

Field_error improved, Boxed error `kind`, explicit naming also for `DecodeErrorKind` #197

Closed Nicceboy closed 7 months ago

Nicceboy commented 8 months ago

Boxed Kind type for error variants. Also some other error improvements.

~~Parser errors from Incomplete and MismatchedTag does not include backtrace anymore. Should restore the performance.~~

XAMPPRocky commented 8 months ago

Thank you for your PR! I'm unsure about making the backtrace optional. Since I'm not sure this is less complex than fixing the decode_sequence_of and decode_set_of

Nicceboy commented 8 months ago

I was also thinking cases if someone builds logic for 'Incomplete' errors, not just the internal handling.

But I can try to find another solution.

Nicceboy commented 8 months ago

I reverted the optional backtrace, maybe it is better to check other changes first