fix char and index maps, enable tests

librasn / rasn

A Safe #[no_std] ASN.1 Codec Framework

Other

199 stars 50 forks source link

fix char and index maps, enable tests #230

Closed Trolldemorted closed 6 months ago

Trolldemorted commented 7 months ago

Fix #229 by having distinct OnceBoxes per implementing type
Enable disabled tests

Trolldemorted commented 6 months ago

I have fixed the formatting issues in the locations I touched. CI should still fail, because there are other locations where cargo fmt complains. Should I fix them too to make CI pass?

Trolldemorted commented 6 months ago

rebased on current master, ran cargo fmt on everything

XAMPPRocky commented 6 months ago

Thank you for your PR, and congrats on your first contribution! 🎉

Trolldemorted commented 6 months ago

I have noticed that the long_sequence_of test is disabled, but it passes on my machine™ (at least now). Was it disabled for this reason, and should be reenabled now as well?

XAMPPRocky commented 6 months ago

If it passes it should be re-enabled, I forget why it was disabled.