enable long_sequence_of

librasn / rasn

A Safe #[no_std] ASN.1 Codec Framework

Other

183 stars 43 forks source link

enable long_sequence_of #232

Closed Trolldemorted closed 3 months ago

Trolldemorted commented 3 months ago

failures:

---- est::tests::csr_attributes_decode_2 stdout ----
thread 'est::tests::csr_attributes_decode_2' panicked at library\alloc\src\raw_vec.rs:570:5:
capacity overflow
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

failures:
    est::tests::csr_attributes_decode_2

test result: FAILED. 5 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1226.99s

Is that an oom error?

XAMPPRocky commented 3 months ago

I believe it's the amount of items exceeds the size of a pointer. The capacity is the size of a pointer on the platform.

Trolldemorted commented 3 months ago

Do you have then any clue why that particular test would fail? Since we smell something fishy again, what could be our causes?

A bug in that version of Rust beta on i686?
A spurious bug that just happens once every few runs?
A bug in rasn that occurs only if you execute it on a x86 machine and not on x64 with cargo test --target i686-pc-windows-msvc?

Could you restart the CI job and we observe whether this happens everytime?

XAMPPRocky commented 3 months ago

I've restarted it now.

XAMPPRocky commented 3 months ago

Seems like it was just spurious. Thank you for your PR!

Trolldemorted commented 3 months ago

Could you fix the CI on the master branch? Then we'd have at least some history of when and how often things fail, right now almost every commit fails