fix(jer): ENUMERATED values as strings

librasn / rasn

A Safe #[no_std] ASN.1 Codec Framework

Other

183 stars 43 forks source link

fix(jer): ENUMERATED values as strings #242

Closed v0-e closed 3 months ago

v0-e commented 3 months ago

Hey there!

The JER standard (X.697 22. 2021) mandates that JER-encoded ENUMERATED values must be JSON strings instead of integers.

First PR here, so let me know if it can be improved in any way, thanks!

6d7a commented 3 months ago

Thank you for your PR! Turns out I've been looking at the wrong spec for the JER implementation :expressionless:, meaning that the entire jer module needs to be revisited. Thank you for noticing!

XAMPPRocky commented 3 months ago

Thank you for your PR, and congrats on your first contribution! 🎉

v0-e commented 3 months ago

@6d7a, I don't know which spec you were looking at, but it looks to me that it is pretty close to X.697 👍 I'll be also testing rasn's JER implementation, so I may be able to help identify and fix any other existing issues.