search

librasn / rasn

A Safe #[no_std] ASN.1 Codec Framework
Other
183 stars 43 forks source link

Standards crates (`rasn-pkix`, `rasn-ocsp`, etc.) should not enable `rasn`'s default feature #246

Closed s-arash closed 1 month ago

s-arash commented 2 months ago

The standards crates enable rasn's default feature, which can incur a significant performance penalty (due to the backtraces feature I assume). These crates should depend on rasn with default-features = false, and turn on whatever features they need individually.

6d7a commented 2 months ago

Thank you for your issue. I would even go as far as to say that we should entirely remove the backtraces feature from default as it's rather a debugging feature, and usually error cases can be easily reproduced. What's your take on it @XAMPPRocky?

XAMPPRocky commented 2 months ago

Yeah I agree, I think the easiest solution is to disable as a default.