staticssleever668
commented
1 year ago Would it be possible for you to build libratbag from source with a patch applied? Although it should only silently fail for unsupported devices, so I doubt we will be able to fix this. https://github.com/libratbag/libratbag#compiling-libratbag
The patch:
diff --git a/src/driver-steelseries.c b/src/driver-steelseries.c
index 8cf8106..665645c 100644
--- a/src/driver-steelseries.c
+++ b/src/driver-steelseries.c
@@ -131,18 +131,24 @@ static int
steelseries_test_hidraw(struct ratbag_device *device)
{
int device_version = ratbag_device_data_steelseries_get_device_version(device->data);
+ if (device_version) {
+ log_error(device->ratbag, "Device version must be specified\n");
+ return -EINVAL;
+ }
/* Rival mice are composite devices with multiple HID devices
* and only the HID vendor device can be used to configure the
* device.
*/
- if (!ratbag_hidraw_has_vendor_page(device))
- return false;
+ if (!ratbag_hidraw_has_vendor_page(device)) {
+ log_debug(device->ratbag, "Skipping wrong HID end-point\n");
+ return 0;
+ }
if (device_version > 1)
return ratbag_hidraw_has_report(device, STEELSERIES_REPORT_ID_1);
else
- return true;
+ return 1;
}
static void
@@ -306,14 +312,18 @@ steelseries_probe(struct ratbag_device *device)
unsigned int report_rates[] = { 125, 250, 500, 1000 };
rc = ratbag_find_hidraw(device, steelseries_test_hidraw);
- if (rc)
+ if (rc) {
+ log_debug(device->ratbag, "Couldn't find hidraw device\n");
return rc;
+ }
rc = ratbag_open_hidraw_index(device,
STEELSERIES_INPUT_ENDPOINT,
STEELSERIES_INPUT_HIDRAW);
- if (rc)
+ if (rc) {
+ log_debug(device->ratbag, "Couldn't open hidraw device\n");
return rc;
+ }
device_version = ratbag_device_data_steelseries_get_device_version(device->data);
if (device_version == -1) {
@@ -410,7 +420,12 @@ steelseries_probe(struct ratbag_device *device)
}
}
- steelseries_read_settings(device);
+ rc = steelseries_read_settings(device);
+ /* Some devices don't support reading settings, so ignore ENOTSUP. */
+ if (rc < 0 && rc != -ENOTSUP) {
+ log_error(device->ratbag, "Error reading device settings\n");
+ return rc;
+ }
return 0;
}
dekart811
daxcore
CounterPillow
ziw-liu
Information
ratbagdversion:0.17Arch LinuxLinux 6.2.1-AMD x86_64 GNU/LinuxDevice info:
Describe the bug The mouse isn't detected by
ratbagctl, even tholibratbagseems to detect it and loads the proper driver.Logs
Additional context Obviously the mouse also doesn't show up in Piper.