Closed cvuchener closed 7 years ago
First one is a G500 using "Switch to profile X" special action that is not supported by libratbag ("UNKNOWN").
If it's not supported by libratbag then Piper can't use it, but I should definitely check whether the key is in the map to prevent Piper from crashing like it currently does.
The second is a G500s with multiple profiles (but libratbag only supports one profile for the G500s). I am not sure what is the exact cause for the crash.
According to your traceback, active-resolution
is None
, meaning that your profile doens't have an active resolution set: https://github.com/libratbag/piper/blob/master/piper/resolutionspage.py#L90 and https://github.com/libratbag/piper/blob/master/piper/ratbagd.py#L407, this is confirmed by your output of ratbag-command info
. As far as I know there should always be an active resolution so this is primarily a libratbag bug, but, again, something that shouldn't make Piper crash. Can you open an issue on libratbag for not having an active resolution on your device?
Thanks for testing by the way, this week I want to solve exactly these kind of issues before we tag a (pre-)release.
your profile doens't have an active resolution set
I see why now. Getting the active profile or resolution is not reliable on HID++1.0 devices. But I don't know a good way to fix that. I'll open an issue on libratbag.
Thanks for testing by the way, this week I want to solve exactly these kind of issues before we tag a (pre-)release.
I have a few more issues but I am not sure how to trigger them yet.
I opened #121 and https://github.com/libratbag/libratbag/issues/281 related to the special mapping issue.
And #122 for broken drivers.
Closing this one for now as there are two PRs solving the issues you mentioned. Feel free to reopen.
I have some mice where I tested weird profiles. Piper crashes when I try to open them.
First one is a G500 using "Switch to profile X" special action that is not supported by libratbag ("UNKNOWN").
The second is a G500s with multiple profiles (but libratbag only supports one profile for the G500s). I am not sure what is the exact cause for the crash.
Output of
ratbag-command info
: