Visual issue on elementary OS

libratbag / piper

GTK application to configure gaming devices

GNU General Public License v2.0

4.82k stars 178 forks source link

Visual issue on elementary OS #294

Open arshubham opened 5 years ago

arshubham commented 5 years ago

Currently piper on elementary OS has a border for frame around sensitivity and Resolution options, and LED dialog. This can be mitigated by just adding frame:{border:0;} in the App css, without any adverse effect on the other themes I tested. I also looks like there is not enough space between Active label and delete icon in resolution list, it is not visible in Adwaita as it doesn't seem the show circular background.

Hjdskes commented 5 years ago

Thanks for reporting this issue. I'm not sure about adding custom CSS to fix themes, so I'll need some time to think about what to do here.

arshubham commented 5 years ago

Thanks for considering. I testing the it on Adwaita using GTK expector for the frame and It looked the same. I will be happy to do some more testing on this. I am not sure about the delete button, if it is a upstream issue or how it is used in piper.

stephanlachnit commented 4 years ago

@whot can be closed since we don't have the delete button anymore.

FFY00 commented 4 years ago

That's not really the whole issue here. The main issue is the border.

stephanlachnit commented 4 years ago

That's not really the whole issue here. The main issue is the border.

Whoops over-read the first part. Still a weird issue though, using Adwaita as well without problems, but not using Pantheon. Still not sure if this is a piper issue though.