search

libratbag / piper

GTK application to configure gaming devices
GNU General Public License v2.0
4.72k stars 175 forks source link

Added svg glorious model o #957

Closed DomHeadroom closed 4 months ago

staticssleever668 commented 4 months ago

Hi! 'check-svg' test seems to be failing.

ERROR:/home/runner/work/piper/piper/data/svgs/glorious-model-o.svg:Missing layer: Device ERROR:/home/runner/work/piper/piper/data/svgs/glorious-model-o.svg:Have button0-leader but not button0 WARNING:/home/runner/work/piper/piper/data/svgs/glorious-model-o.svg:Non-consecutive button: button1 ERROR:/home/runner/work/piper/piper/data/svgs/glorious-model-o.svg:Missing style property for button1-leader ERROR:/home/runner/work/piper/piper/data/svgs/glorious-model-o.svg:Missing style property for button2-leader ERROR:/home/runner/work/piper/piper/data/svgs/glorious-model-o.svg:Have button3-leader but not button3 ERROR:/home/runner/work/piper/piper/data/svgs/glorious-model-o.svg:Have button4-leader but not button4 WARNING:/home/runner/work/piper/piper/data/svgs/glorious-model-o.svg:Non-consecutive button: button5 ERROR:/home/runner/work/piper/piper/data/svgs/glorious-model-o.svg:Missing style property for button5-leader INFO:/home/runner/work/piper/piper/data/svgs/glorious-model-o.svg:Found 6 buttons ERROR:/home/runner/work/piper/piper/data/svgs/glorious-model-o.svg:Have led0-leader but not led0 INFO:/home/runner/work/piper/piper/data/svgs/glorious-model-o.svg:Found 0 leds

DomHeadroom commented 4 months ago

Ok I will try to fix it later when I get home

DomHeadroom commented 4 months ago

Ok I think the tool I used to reduce the size of the svg removed some metadata and now I need to get the original from my Desktop pc and I 'll be able to only in some months

DomHeadroom commented 4 months ago

Ok I put the id's myself on the svg manually, but for the style issue I don't know how to solve it because the style is there on the svg but the python script always tell there is no style.

For example it say "ERROR:glorious-model-o.svg:Missing style property for led0-leader" even tho led0-leader is

And the same style is used in the glorious model d svg.

This is the new svg anyway glorious-model-o

staticssleever668 commented 4 months ago

Thanks!