Fix gaps in Docker plugin metrics - Githubissues

librato / librato-collectd-docker

Collectd plugin for Docker cgroup metrics

MIT License

9 stars 7 forks source link

Fix gaps in Docker plugin metrics #12

Closed vaidyg closed 8 years ago

vaidyg commented 8 years ago

Attempts to fix a customer reported issue where the docker curated dashboard charts show a lot of gaps. See https://app.intercom.io/a/apps/i5t8536a/inbox/conversation/5058379720

The following fixes seem to help quite a bit.

Adjust the sleep interval to account for the delay in fetching docker metrics (can exceed 3 seconds).
Avoid compiling regular expressions repeatedly
Flush metrics to stdout so that they are visible to the collectd master process immediately

See before and after screenshots below.

Before:

/cc @akahn or @chancefeick or @bryanmikaelian

akahn commented 8 years ago

Looks good, I like it.