Remove support for ruby 1.8

librato / librato-metrics

Ruby wrapper to make it easy to interact with Librato's API.

https://librato.com

Other

108 stars 51 forks source link

Remove support for ruby 1.8 #119

Closed chancefeick closed 8 years ago

chancefeick commented 8 years ago

Remove support for ruby 1.8. Introduce the following changes:

Use 1.9 hash syntax
Remove Faraday version lock (current version is 0.9.2, previously locked at 0.7)
Remove MultiJSON runtime dependency (JSON ships w/ >= 1.9, only use MultiJSON if defined)

2.0 roadmap: #110

@nextmat lmk if any other improvements/oversights come to mind

bdehamer commented 8 years ago

👍

nextmat commented 8 years ago

We should probably add a required ruby version to the gemspec.

nextmat commented 8 years ago

This generally looks good to me. Total nit but in the future you might want to do something like this in two pieces:

PR 1) functional changes PR 2) formatting changes (hashrockets, etc)

Just to make review a bit more manageable.

Also we should make sure the full integration suite passes (not run by Travis) before this is merged, lmk if you need any help to run this.

chancefeick commented 8 years ago

@nextmat added required version in 33c00151775cf438148505110e7c61b729e424ed and refactored SmartJSON w/ tests in 58bf7ae957de241793175288e2ecc64927da22bc, PTAL.

:+1: on breaking it out into functional/style changes in the future to prevent larger diffs.

RE: integration tests, they appear to have already been failing on master, unrelated to recent changes. Will get those passing in another PR and merge into 2.0 branch.