Closed ys closed 7 years ago
@ys - thanks for raising this issue. I think we may need more than you include here for debugging purposes but we can definitely be more selective. Thanks for starting this.
@nextmat As long as you do something quick to stop creds leaking to bug trackers, I am fine with any solution.
Done in #130
Passing everything means that if it raise to an error tracker you might end up leaking credentials.
Raising the whole
env
will also leak request headers like Authorization.The fact that the first parameter is a string means a lot of the bug trackers won't filter and scrub it.
Work here is simply taking https://github.com/lostisland/faraday/blob/master/lib/faraday/response/raise_error.rb and applying it here.