Set minimal version needed for Faraday

librato / librato-metrics

Ruby wrapper to make it easy to interact with Librato's API.

https://librato.com

Other

108 stars 51 forks source link

Set minimal version needed for Faraday #134

Closed jeandenis-k closed 7 years ago

jeandenis-k commented 7 years ago

Hi, I had some crashes with this gem using faraday 0.8: the middleware ExpectsStatus expects faraday env objects to have a status method, which they only have since faraday 0.9.

nextmat commented 7 years ago

Hmm, this change was recently introduced in #132, are you able to upgrade faraday? If not we may want to ensure we can still support 0.8.x as well.

jeandenis-k commented 7 years ago

Yes, I was able to upgrade faraday, everything works on our end now :)

I don't really see the connection between #132 and this though, but maybe that's just me!

nextmat commented 7 years ago

Whoops, I meant #130 - that's where we added the call to status.

chancefeick commented 7 years ago

Thanks for the initial report. Faraday 0.8.x support was re-added in #138 and released in v2.1.2.