Closed oggy closed 7 years ago
Ah, I just saw the discussion in #134 . I'll see if Faraday 0.9 will work for us.
Either way, I think either a version requirement should be set, or support for 0.8 should be added.
Yeah I agree. We should fix this so it works cleanly with 0.8.x+
Great! As a data point we've been running with this patch for the past week or so and no problems for us.
@oggy Thanks for your contribution. Released in v2.1.2.
We're seeing
env
come through as aHash
rather than aFaraday::Response
here. Faraday's middleware docs are poor, but it seems common to look up environment values using[]
rather than relying on the methods ofResponse
, presumably because this can happen.If it makes a difference, we're using Faraday 0.8.11, but
librato-metrics
does not specify any version requirements.