Closed jasonrudolph closed 4 years ago
Can you and @magni- and @irphilli try this out in production applications and report back on how it goes for you?
@akahn We've been using a fork of the 1.x branch with the relaxed constraint (with faraday v0.17.3
) on our main app at @rainforestapp for three months now, no issues.
Closes https://github.com/librato/librato-metrics/issues/142.
This pull request relaxes the faraday version constraint so that consumers of this gem can use newer versions of faraday that support Ruby 2.7.
Please note that this pull request targets the librato-metrics 1.x branch, as some Librato customers cannot upgrade to 2.x.
Because faraday 1.0 introduces a breaking change regarding the namespacing of its error classes, this pull request updates the
Faraday::Error::ConnectionFailed
reference to useFaraday::ConnectionFailed
instead. This change is backwards compatible with older versions of faraday. Without that change, you see the following failure when running the test suite with faraday 1.0.0: