fix: Avoid deprecation warning about #basic_auth on Faraday::Connection - Githubissues

librato / librato-metrics

Ruby wrapper to make it easy to interact with Librato's API.

https://librato.com

Other

108 stars 51 forks source link

fix: Avoid deprecation warning about #basic_auth on Faraday::Connection #147

Open olleolleolle opened 2 years ago

olleolleolle commented 2 years ago

This change avoids a deprecation warning.

The authentication method "helpers" have been moved out of the Connection object.

This change makes us use the "request middleware called ":basic_auth" directly, instead.

Details

https://lostisland.github.io/faraday/middleware/authentication
https://github.com/lostisland/faraday/blob/main/UPGRADING.md#authentication-helper-methods-in-connection-have-been-removed
Include both the upcoming Faraday 2.0 signature, too.

Notes

While doing this, I noted that the test suite does not run, so I added a new GitHub Actions CI configuration, in #148.