search

librato / librato-metrics

Ruby wrapper to make it easy to interact with Librato's API.
https://librato.com
Other
108 stars 52 forks source link

Add support for snapshots API #94

Closed paul closed 10 years ago

nextmat commented 10 years ago

Looks good :+1:

nextmat commented 10 years ago

I thought this was ready and merged it but ran into issues getting the tests to actually work. The API requires an instrument to exist for the snapshot routes to act on and there isn't accounting for that here.

Reverted for now, note we'll have to revert the revert when re-merging.

paul commented 10 years ago

@nextmat this gem doesn't implement the instruments API, so I'm not really sure how to go about creating the instrument used for the test. Any ideas?

nextmat commented 10 years ago

I think probably the best approach is going to be to grab the connection object and do a manual post to the right route using it. You should be able to get it from Metrics.connection or Metrics.client.connection.