search

librato / librato-services

Services for Librato Metrics
MIT License
14 stars 24 forks source link

Bugfix/encode hipchat room #126

Closed bryanmikaelian closed 9 years ago

bryanmikaelian commented 9 years ago

This should ideally prevent any mishaps if a HipChat room has spaces in it. Wrapped URI::encode into a method just for style purposes.

obfuscurity commented 9 years ago

@bryanmikaelian What sort of results did you get with/without encoding in testing against our Hipchat account?

bryanmikaelian commented 9 years ago

@obfuscurity In both cases (room with spaces and with encoded spaces), I found I was able to send messages to said room just fine. I did notice, too, that the hipchat-rb gem does pass in application/x-www-form-urlencoded header when making a POST to their v1 API but not their v2 API here: https://github.com/hipchat/hipchat-rb/blob/master/lib/hipchat/api_version.rb#L21-L22

bryanmikaelian commented 9 years ago

Holding on this for now