librato / python-librato

A Python wrapper for the Librato Metrics API.
Other
72 stars 31 forks source link

Setting name for line from API doesn't show in Web UI #144

Open andrewmkrug opened 7 years ago

andrewmkrug commented 7 years ago

Setting a name doesn't load until the graph is resaved from the ui.

psuedo-code to reproduce:

name = 'Custom Name for line'
streams = []
streams.append({'metric': metric, 'source': source,'name': name})
chart = librato_api.create_chart(graph.name, space, streams=streams)
# this next line was an attempt to trigger the save that gets the name to show up
chart.save()

At this point, if you go to the space in the web ui it will have the generic name set to the source. However, if you go to the properties of the line the name is set correctly.

To have the name get properly set then the chart has to be saved from the UI.

I have tried calling the save method for the chart from the api to see if that will trigger the name to properly show up.

niklibrato commented 7 years ago

Hi @andrewmkrug - thanks for reporting this! We will take a look.

jderrett commented 7 years ago

Hi @andrewmkrug, thanks for the bug report. Unfortunately I'm not able to reproduce this. If you can see here what I'm missing or have more details, please let us know and we'll get it fixed up!

>>> s = api.get_space(110020)
>>> chart = api.create_chart('test cpu', s, streams=[{'metric': 'AWS.EC2.CPUUtilization', 'source': 'nanobox1', 'name': 'name of line'}])
>>> chart.streams[0].name
'name of line'

test___librato

andrewmkrug commented 7 years ago

not sure if it would affect it but the source that i am using is a search pattern eg *-1234

drio commented 7 years ago

@andrewmkrug Can you share your user name and the space you are using for testing this?

andrewmkrug commented 7 years ago

andrew at revcontent.com the space name is "Viewability Performance Tracking"