search

librato / python-librato

A Python wrapper for the Librato Metrics API.
Other
72 stars 31 forks source link

Python bug sending tags from queue #170

Closed mtanski closed 7 years ago

mtanski commented 7 years ago

It looks like there's a bug in the code at: https://github.com/librato/python-librato/blob/master/librato/queue.py#L139

c['tags'] = dict(self.tags).update(c['tags'])

dict.update function does not return anything (None) so it overwrites c['tags'] with None

jderrett commented 7 years ago

@mtanski thanks very much for the bug report. We'll see about getting this fixed shortly.

mbeale commented 7 years ago

@mtanski good point. I'll update the code. I think the following will do it:

c['tags'] = dict(dict(self.tags), **c['tags'])
mbeale commented 7 years ago

This is addressed in https://github.com/librato/python-librato/pull/172