Improvements / bugfixes before releasing Alerts - Githubissues

librato / python-librato

A Python wrapper for the Librato Metrics API.

Other

72 stars 31 forks source link

Improvements / bugfixes before releasing Alerts #80

Closed jderrett closed 9 years ago

jderrett commented 9 years ago

Making a few enhancements before releasing alert support into the wild

Fixed some comments
Removed some whitespace
Hydrate active flag when loading an Alert
Added immediate() instance method to Condition model for convenience / interrogation
list_alerts() defaults to only show active alerts
Fix issue in integration test where 400s come back because metric names might not exist
Attempt to use constants for some hardcoded attribute names
delete_alert() doesn't need any query_props so removed those

@mauricioborges I've made a few tweaks and a bug fix or two after #76 and plan to release this tomorrow unless you see any blockers, thanks!

mauricioborges commented 9 years ago

@jderrett for me it's great, you did lots of improvements I missed, thanks