search

librato / statsd-cookbook

Chef cookbook to install Statsd
Apache License 2.0
26 stars 36 forks source link

non-npm backends #33

Open TanmayaAPYL opened 10 years ago

TanmayaAPYL commented 10 years ago

Possible for you to allow install of non-npm backends like this one? https://github.com/lucidsoftware/statsd-smart-repeater

mheffner commented 10 years ago

@TanmayaA I feel like that may make the base statsd-cookbook bloated if we tried to support a lot of external backends this way. IMO, there should be a smart-repeater-cookbook that depends on the statsd-cookbook, but isolates any specific requirements for smart-repeater. Maybe the statsd-cookbook could have a resources function that made adding a backend to the base statsd configuration easier?

TanmayaAPYL commented 9 years ago

@mheffner Sorry, I missed notification of your reply. I'm ok to do a smart-repeater-cookbook, however, as you said we do need some function to make this happen, without having to override the statsd configuration itself. Possible for you add this feature sometime soon?

Thank you for your time and efforts!

mheffner commented 9 years ago

@TanmayaA Unsure when I'll have time to take a stab at this. If you've got some time to put a PR together I can certainly take a look.

I think if the resource merged attributes in the extra_config parameter it could work: https://github.com/librato/statsd-cookbook/blob/master/attributes/default.rb#L76

TanmayaAPYL commented 9 years ago

Thanks for the quick response. I have to work on it soon in any case. Will try to make a PR then.

varunpalekar commented 9 years ago

How can I add non npm backends since there is no attribute to include extra backends in main config.js file of statsd.