added line to upstart config to write the statsd pid file using the d…

librato / statsd-cookbook

Chef cookbook to install Statsd

Apache License 2.0

26 stars 36 forks source link

added line to upstart config to write the statsd pid file using the d… #37

Closed DocLabyrinth closed 9 years ago

DocLabyrinth commented 9 years ago

The cookbook supplies an attribute to configure where the pid file is written to, but unless I missed something it wasn't actually being used. This caused me problems when trying to get monit to monitor statsd. The change in this pull request solved the problem and the pid file is now generated as expected

mheffner commented 9 years ago

@DocLabyrinth Makes sense. Should the PID file be removed in a post-stop section?

DocLabyrinth commented 9 years ago

Post-stop section added by https://github.com/prioridata/statsd-cookbook/commit/382f8afdfd2de28d5de606c2bc10cadcb82593e7

mheffner commented 9 years ago

@DocLabyrinth Why the addition of the vsysinit bits? I think that should ideally be in a different PR.

DocLabyrinth commented 9 years ago

Ah sorry my mistake I forgot the vsysinit commit was also in there, i'll split it into two PRs