versioning, smartos support, specific interface binding, and repeaters

librato / statsd-cookbook

Chef cookbook to install Statsd

Apache License 2.0

26 stars 36 forks source link

versioning, smartos support, specific interface binding, and repeaters #6

Closed sax closed 10 years ago

sax commented 12 years ago

This is a lot of changes, so I would understand if you do not want to pull this upstream. I figured I'd start a pull request, though, to see if you want any of these changes.

add ability to lock down statsd version
add smartos support, for installing service via SMF
add support for repeaters (via search)
graphite host can be found via search
binding (and message passing) can be specified on public or private interfaces. This allows us to only bind private IP addresses on a VLAN.

If you see any problems or prefer anything done differently, let me know!

mheffner commented 12 years ago

@sax This is great! Just two remarks:

What is ohai-private-ipaddress? Can that include only be used if they are using the code-paths that require it? Seems like that might create an unneeded dependency for a lot of users.
Potentially similar to above, but what is the graphite[bind] setting for?

sax commented 12 years ago

Hmmm you're right. In the long run I think the private-ipaddress stuff should be in ohai, but I'm just getting familiar with that codebase. It was my attempt to centralize the code for finding RFC1918 addresses, which we use to keep our private services off the public internet.

In the meantime, I'll refactor it so it only gets loaded when necessary. I'll also add to the readme, so the bind stuff makes more sense. Basically, if your graphite server is multi-homed, it lets you choose whether to bind the public or private ip.

mheffner commented 10 years ago

My apologies for not staying on top of this. It looks like many of these changes have been incorporated since through various PRs. Can you resubmit any remaining deltas?

sax commented 10 years ago

It's fine closing this. Since then, we've completely changed how we manage public/private IP addresses and don't use ohai-private-ipaddress any more.

On Tue, Jul 29, 2014 at 1:19 PM, Mike Heffner notifications@github.com wrote:

My apologies for not staying on top of this. It looks like many of these changes have been incorporated since through various PRs. Can you resubmit any remaining deltas?

— Reply to this email directly or view it on GitHub https://github.com/librato/statsd-cookbook/pull/6#issuecomment-50532414.

e s