search

librato / statsd-librato-backend

A StatsD backend that sends metrics to Librato Metrics
MIT License
76 stars 34 forks source link

Gauge y-axis properties missing. #28

Closed ahawkins closed 7 years ago

ahawkins commented 11 years ago

I think the gauges should set the proper y-axis properties. They're described here: http://dev.librato.com/v1/metric-attributes. I think it makes sense to set the display_units_long to "Milliseconds" and the display_units_short to "ms". This is the most common case. You cannot correctly stack metrics inside librato unless they have the same y-axis values. This change would make out of the box experience much nicer.

mheffner commented 11 years ago

@ahawkins I assume you are referring to the timer statsd metrics specifically? I think the "timer" name for those metrics is somewhat misleading; oftentimes those metrics are used simply to record any metric that can have multiple samples. I'm hesitant to set "Milliseconds" as a default label as that may not apply in many circumstances.

On the Librato product side we recently added the ability to mass-set metric y-axis-label's from inside an instrument. This makes it easier to stack all metrics on the same y-axis-label: http://blog.librato.com/posts/2013/8/12/enhanced-instrument-composition.

We've also discussed automatically stacking all metrics that don't have a y-axis-label set on the same y-axis-label. This may be added to the product in the future and should also help with this scenario.