search

librato / statsd-librato-backend

A StatsD backend that sends metrics to Librato Metrics
MIT License
76 stars 34 forks source link

fix broken timers on the new tagged measurements #73

Closed netroy closed 7 years ago

netroy commented 7 years ago

wrote them as 3 commit to TDD the behavior.. the tests fail on the second commit. Please feel free to squash them when merging.

bryanmikaelian commented 7 years ago

@netroy Thanks for the PR. Just to confirm, are you only seeing broken timers for the sum aggregate?

bryanmikaelian commented 7 years ago

Nailed down the commit where this broke: https://github.com/librato/statsd-librato-backend/commit/8bc40dc3b01019489b08d07f2756c51ec827cbad#diff-2ae335a2155c51431a9d83207bf6f5fbL197

netroy commented 7 years ago

@bryanmikaelian yep.. since by default we see the average of sums, unless I group things, I only see flat lines.

netroy commented 7 years ago

@bryanmikaelian updated

bryanmikaelian commented 7 years ago

🆒 Will get this merged and released to npm. Thanks @netroy. Great catch! 🐟

netroy commented 7 years ago

most welcome, thanks for the quick review .. cheers 😄 would it be possible to have an npm release today? if not, i can use the git url temporarily.

bryanmikaelian commented 7 years ago

Absolutely! Publishing now. Should be available soon.