search

libre-computer-project / libretech-wiring-tool

Other
25 stars 22 forks source link

Add dts for MCP3008 on aml-s905x-cc #6

Closed anguselheimStudios closed 1 year ago

anguselheimStudios commented 1 year ago

I added the overlay for the MCP3008 ADC as discussed here:

https://hub.libre.computer/t/problems-accessing-mcp3008-via-spi-invalid-argument/1844

This is my first ever pull request, so please let me know if I've done something wrong or broken etiquette in any way. Git/Github is confusing for a newbie.

dsx724 commented 1 year ago

Thanks for contributing!

Here is the feedback for the pull request: 1) The proper compatible is microchip,mcp3008. 2) You also should have a status = "okay"; field. 3) The lable/symbol name mcp3008_00 is not necessary. Either remove it if it will not be extended via further overlays. If it will be extended, then we recommend prefixing it with the pre-requisite overlay as part of the the identifier.

The text representation of the AML-S905X-CC device tree can be found here: https://boot.libre.computer/ci/aml-s905x-cc.dts Please squash these changes into a single commit and resend the pull request.