search

libre-ops / metabase

Ansible role for provisioning Metabase
https://galaxy.ansible.com/libre_ops/metabase
GNU General Public License v3.0
14 stars 7 forks source link

Adds jvm args #2

Closed mcg closed 5 years ago

mcg commented 5 years ago

Fixes #1

Didn't use default(omit) as you suggested as that's apparently not the intended usage for omit. See https://github.com/ansible/ansible/issues/44261 for some explanation.

Matt-Yorkley commented 5 years ago

Didn't use default(omit) as you suggested

Ah yes, it's a template so omit doesn't work, but we could have used: {{ metabase_jvm_args | default("") }}. Anyway, it's fine like this. :+1:

Matt-Yorkley commented 5 years ago

Hey @mcg I did some testing and added this as well: #3.

There's now a new release: https://github.com/libre-ops/metabase/releases/tag/1.0.2 and it's up on ansible galaxy.

mcg commented 5 years ago

Thanks for getting this pushed out . Didn’t want to have to use my branch.