search

libre-ops / metabase

Ansible role for provisioning Metabase
https://galaxy.ansible.com/libre_ops/metabase
GNU General Public License v3.0
14 stars 7 forks source link

Support newer versions of metabase #8

Closed hauthorn closed 3 years ago

hauthorn commented 3 years ago

While trying out your role with v0.37.0.2, I noticed a bug in tasks/configure.yml that would cause an error.

The response from http://localhost:{{ metabase_port }}/api/session/properties would response with the setup token under the key setup-token (with a dash) and not with an underscore.

This caused the configuration to fail because the code could not look up the value in the dictionary. (tested on Ansible 2.9. and python 3.8. on Ubuntu)

I hope this is useful to you - feel free to ask me to change something or test something to help you merge this.

Matt-Yorkley commented 3 years ago

Thanks @hauthorn! :heart:

I'm currently using Metabase v0.36.x in production and was about to upgrade it this week. I'll take a look and sort out a new release :+1:

Matt-Yorkley commented 3 years ago

@hauthorn I've tested, merged, released and updated Ansible Galaxy :+1:

You can bump libre_ops.metabase to version 1.0.5 to pick up the changes.