search

libre-server / rolekit

'rolekit' is a daemon for Linux systems providing a stable D-BUS interface to manage the deployment of ​Server Roles.
19 stars 7 forks source link

Instance name should not contain "/" #40

Closed t-woerner closed 8 years ago

t-woerner commented 8 years ago

The name of a role should not contain "/". This results in a trace back in the daemon or in rolectl for deferred deployments.

Maybe name should be alpha-num with some additional characters like '_', '-', '@', ..

t-woerner commented 8 years ago

This is the regular expression for instance name checking: ^[A-Za-z0-9][A-Za-z0-9-.]*$ The instance name needs to start with a alpha-numeric character, then also '', '-' and '.' are allowed. The '.' is needed for the Domain Controller use case.

'@' is not allowed, it will collide with systemd.

sgallagher commented 8 years ago

That looks good to me.

Good catch on the @ as well. Best not to get in the way with systemd.