libre-server / rolekit

'rolekit' is a daemon for Linux systems providing a stable D-BUS interface to manage the deployment of ​Server Roles.
19 stars 7 forks source link

Role setting JSON files have the wrong permissions #44

Closed sgallagher closed 8 years ago

sgallagher commented 8 years ago

This bug is security-sensitive but is already publicly disclosed.

The RoleSettings class has a write() method that was not properly using umask. As a result, JSON files were written to disk as world-readable, which could lead to a leak of sensitive information such as auto-generated passwords. On 0.4.0rc1, this could also lead to a leak of manually-entered passwords specified at kickstart time.