libre-server / rolekit

'rolekit' is a daemon for Linux systems providing a stable D-BUS interface to manage the deployment of ​Server Roles.
19 stars 7 forks source link

Put instances in error state if it is transitional while roled starts #45

Closed t-woerner closed 8 years ago

t-woerner commented 8 years ago

If roled was dying or killed while an instance is in a transitional state, then there is no way to change this state using rolekit interfaces. Not even a decommission --force is possible.

Proposal from Stephen: When roled starts, any role that is marked 'deploying' is immediately marked 'error'

sgallagher commented 8 years ago

We need to make sure that we mark these as "error" before we start answering requests from D-BUS or we might end up with race-conditions (marking a legitimately just-started deployment or decommission as an error)

sgallagher commented 8 years ago

(09:33:48 AM) twoerner: it should be simple to do in DBusRole.init (09:34:01 AM) twoerner: after loading the role instance settings

t-woerner commented 8 years ago

This is not fixed completely, see issue 52

nphilipp commented 8 years ago

Issue #52 is closed now, so I think that this one should be closed, too.