libre-tube / LibreTube

An alternative frontend for YouTube, for Android.
https://libretube.dev
GNU General Public License v3.0
8.65k stars 443 forks source link

Small design changes #2578

Closed Silther closed 1 year ago

Silther commented 1 year ago

Describe your suggested feature

  1. Autoplay button Change the look of the button from a filled in to an outlined design, to fit in with the over icons (and maybe make it smaller).

    Autoplay button
  2. Library filter Swap the icon and text, so it looks more symmetrical und the icon doesn't move if you change from all to video etc (and maybe make the icon smaller).

    Library filter
  3. Playlist order Show the bookmarks above the Playlist, so that everything does not shift when the playlist reloads

    Playlist order
  4. Bookmark option Add an Bookmark option to the long press menu of a public playlist.

    Bookmark option
  5. Color Changes In the monochrome design, I wasn't able to find the color that the "new video indicator" uses and therefore the indicator is barely visible when the subscription tab is selected.

    Color changes
  6. Bookmark Font Size (Edit) enlarge the font of the bookmark title to that of the playlist title

    Bookmark Font Size

Other details

No response

Acknowledgements

Bnyro commented 1 year ago

I'm not really a fan of 3. since user playlists are way more important than bookmarks, so we should keep them ordered by priority as currently.

  1. will be a bit challenging because we'll need to create custom layer drawables for that which is not that straight-forward, I doubt I'll work on that. Anything else seems reasonable.
Silther commented 1 year ago

I'm not really a fan of 3. myself. Could you save how many playlist you have, and show an empty space until they are loaded, so that the bookmarks are not pushed down when the playlists are loaded?

Silther commented 1 year ago

Added 6.

Bnyro commented 1 year ago
  1. can be solved the same way the black circle at the thumbnail gets removed/fixed.
Bnyro commented 1 year ago

I'm not really a fan of 3. myself. Could you save how many playlist you have, and show an empty space until they are loaded, so that the bookmarks are not pushed down when the playlists are loaded?

I doubt that's a good idea since they can be changed by the Piped account, the best way for us is probably to leave it as it is :)

Bnyro commented 1 year ago

Talking about 2., I think that it looks better if we keep the icons at the right for both options because making it symmetrical "mirrors" the two which makes it look a bit weird to me.

Bnyro commented 1 year ago

The notification badge uses color primary now, but we can switch it to any other color you want (as long as it would still look fine with the other themes) (I just realized colorPrimary was probably a bad choice as the highlighted navigation item has the same color maybe, not sure, needs to be tested). The only remaining thing would be the autoplay button, but I'd prefer having a separate issue for it which we leave open for external contributors and not me.

Silther commented 1 year ago

I doubt that's a good idea since they can be changed by the Piped account

I would say the most people use only the app and if a different number of playlists is loaded fron piped the predefined empty spaces can be overwritten.

But as it's your app you have the last word.

Silther commented 1 year ago

The notification badge uses color primary now, but we can switch it to any other color you want (as long as it would still look fine with the other themes) (I just realized colorPrimary was probably a bad choice as the highlighted navigation item has the same color maybe, not sure, needs to be tested).

I'll see if I can find a better color palette for the monochrome theme, but it might take a while. #2111

The only remaining thing would be the autoplay button, but I'd prefer having a separate issue for it which we leave open for external contributors and not me.

I will open one soon.