libre-tube / LibreTube

An alternative frontend for YouTube, for Android.
https://libretube.dev
GNU General Public License v3.0
8.57k stars 441 forks source link

Some GUI suggestions #4426

Closed SameenAhnaf closed 1 year ago

SameenAhnaf commented 1 year ago

Describe your suggested feature

Screenshot_20230811-185324 Screenshot_20230811-185249

Other details

No response

Acknowledgements

Bnyro commented 1 year ago

Changing the autoplay icon has already been discussed in an other issue and I currently think that our icon is good enough to stay in the app.

Always showing the progress bar has already been rejected in previous issues and still is not planned, also because it doesn't fit the overall app UI.

I don't see the point of a playback speed/pitch reset button, since you can just reset the individual options for it which is only a single click more. There's no reason to bloat the UI with that.

Embed orderly, shuffled and reverse playback into the same icon.

Could you please explain what you mean exactly?

In order to access playback speed, audio tracks, captions and resolution, show detailed menu right below the selected option for both main & full screen players and don't cover the entire screen in case of full screen player. Much more easier to access.

That's how the app behaved once, however I changed it for UI reasons - and still think it's the right decision to keep it as is. There's also an other open issue on accessing them quicker.

Also, move position holders of videos in play queue to left of thumbnail.

Why?

Bnyro commented 1 year ago

Please separate such suggestions into separate issues (one per suggestion) next time - it makes it much easier to track them, and for new contributors to work on some of it.

SameenAhnaf commented 1 year ago

I don't see the point of a playback speed/pitch reset button, since you can just reset the individual options for it which is only a single click more. There's no reason to bloat the UI with that.

I was actually requesting to declutter the UI. Instead of two reset buttons, introduce just one which will instantly reset speed and pitch and close speed playback menu.

Embed orderly, shuffled and reverse playback into the same icon.

Now there are separate icons from Reverse and Shuffle queue action. Instead of two separate icons, embed these actions into a single icon with three states: Orderly (as usual), Shuffled and Reverse.

Make all scrollers grabbable to easily reach top of the page. Also, move position holders of videos in play queue to left of thumbnail.

Scrollers are on right. If they become grabbale, changing position will contradict with position holders in play queue. This is what scrollers are supposed to do.

Recording 1 https://github.com/libre-tube/LibreTube/assets/79245641/2dd9779a-0fce-4b3a-9d29-afa66b0ce1b0
Bnyro commented 1 year ago

Now there are separate icons from Reverse and Shuffle queue action. Instead of two separate icons, embed these actions into a single icon with three states: Orderly (as usual), Shuffled and Reverse.

The actions can't be undone. For instance, if you shuffle the queue, you can't restore the previous order.

I'm not sure if you tested the latest debug builds, but recently I added an option to sort the queue by upload date, views, and uploader name. The sort options are being listed in a dialog.

So I think it would make sense to remove the reverse and shuffle action and add them to the new sort dialog instead as options. What do you think?

SameenAhnaf commented 1 year ago

remove the reverse and shuffle action and add them to the new sort dialog instead as options. What do you think?

Yeah, that could be a great option too.

Btw, I removed rejected features from description and added a new one.

Bnyro commented 1 year ago

Show remaining time adjusted with playback speed.

I don't think any other app behaves like that when it comes to the calculation of the remaining time, so I honestly doubt that'd be a good idea that's self-explaining to users.

Bnyro commented 1 year ago

On landscape full screen player, stick all options on the left half of the screen, no need to cover entire screen.

Doing that will require creating a different layout for landscape than for the portrait mode - which is not planned, or a duplicate of #3198.

Bnyro commented 1 year ago

Show only one RESET button to quickly adjust both speed and pitch and close speed menu too on a single click. Keep it as in the same line of Skip Silence option. No need for two RESET buttons.

I don't think it would be self-explaining what they actually do. I think we could remove the reset buttons in general, since we now have shortcuts to choose certain speeds above the slider, so the user can just choose "1.0" instead of clicking the reset button.

SameenAhnaf commented 1 year ago

3198 is asking for a layout for landscape main player which is especially for tablets and TVs. My suggestion was specifically for landscape full screen player.

Bnyro commented 1 year ago

Yes, but that would be the same problematic.

Bnyro commented 1 year ago

Make all scrollers grabbable to easily reach top of the page. Also, move position holders of videos in play queue to left of thumbnail.

Please make a list with all parts of the app where scrollbars are missing in a new issue.

Bnyro commented 1 year ago

Concerning moving the position holders to the left, I don't agree because I think that makes it harder to grab them.