libre-tube / LibreTube

An alternative frontend for YouTube, for Android.
https://libretube.dev
GNU General Public License v3.0
8.5k stars 441 forks source link

Opening a video from the mini-player moves the video to a corner #5816

Open JustMarkov opened 5 months ago

JustMarkov commented 5 months ago

Steps to reproduce

  1. Open the video
  2. Swipe it down to the mini-player
  3. Open the video from the mini-player

Expected behavior

The video should open normally.

Actual behavior

The video shifts to the corner after opening.

LibreTube version

0.22.1

Android version

Android 14

Other details

If you open the video full screen / rewind the video, it will fall into place. Here's a screen recording:

https://github.com/libre-tube/LibreTube/assets/67514343/561698db-6cc5-47b4-9823-d048dd179270

Acknowledgements

Bnyro commented 5 months ago

Please share a screen recording.

akano12 commented 5 months ago

Please share a screen recording.

There's already a recording attached. Just expand the Details section and you'll see it (under the Other Details)

JustMarkov commented 5 months ago

Please share a screen recording.

It is already there, under the Details section.

TechnoSparks commented 4 months ago

Went as far back to v0.21.1 and this bug still happens on my primary Android 14 device. Not reproducible on my Android 13 device. Could it be QPR2 that causing this regression?

Bnyro commented 4 months ago

Yes, probably some Android battery / performance improvements :/

TechnoSparks commented 2 months ago

I notice that the underlying problem is the video does not (or sometimes will) resize based on the container when we drag up slowly the mini-player. What if we could instead trigger a resize (or repaint?) of the video content when the player is now no longer a mini-player?

PJansky commented 2 months ago

Newpipe had a very similar issue. This thread might give insight into how they solved it or their fix might even be applicable here even though the "fix" looks like major refactor https://github.com/TeamNewPipe/NewPipe/issues/7262