libre-tube / LibreTube

An alternative frontend for YouTube, for Android.
https://libretube.dev
GNU General Public License v3.0
8.53k stars 440 forks source link

Pure Theme not applying to the Navation bar #5877

Closed kokopossum closed 5 months ago

kokopossum commented 5 months ago

Steps to reproduce

Step 1 : Enable Pure Theme in Settings> Appearance >Pure Theme

Step 2 : Reload the app as prompted, then look at the main page Navigation bar

Expected behavior

The Navigation bar should match the pure light or dark theming for a clean look.

Ex if the app in pure theme mode dark, the Nav bar should be #000000 (black) not #1F1E23 (grey)

Actual behavior

The Navigation bar does not change with pure theme mode and therefore, does not match with the "pure" themed application. Screenshot_20240408_201510_LibreTube

LibreTube version

0.22.2

Android version

Android 14

Other details

No response

Acknowledgements

imwints commented 5 months ago

The Navigation bar should match the pure light or dark theming for a clean look.

I don't think it should. There are some elements that always have a surface tint, like the overflow menu or the navigation bar. I'd rather colorize the title bar on scroll than remove the color on the navigation bar

Bnyro commented 5 months ago

I agree with @imwints that it shouldn't be 100% black.

It's now darker than before, but still can be distinguished from the other content due to the fact that it's color is slightly different.

imwints commented 5 months ago

This just made the overflow menu black, which makes it look really weird

imwints commented 5 months ago

Screenshot_20240410_012837_LibreTube Debug