Release 0.24.0 (PLEASE TEST!)

Bnyro commented 5 months ago

Beta-Testers searched for upcoming 0.24.0 release

The app is on a feature freeze now until the next release, so it's important to test it to avoid any major bugs and the necessity of hotfix releases.

Please test the app builds from https://github.com/libre-tube/NightlyBuilds and report any regressions here or in a new issue.

Thank you!

Changelog

New features

feat: download popup that can be displayed over other apps by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6034
feat: changed chips in channels to swipable tabs by @amandeepsinghjamwal in https://github.com/libre-tube/LibreTube/pull/6026 and https://github.com/libre-tube/LibreTube/pull/6053
feat: support for external download apps by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6084
feat: minor channel page header redesign by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6123
feat: remember selected channel group across app restarts by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6132

Bug fixes

fix: button to play previous video doesnt work when repeat enabled by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6035
fix: chapters dont work in audio mode by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6055
fix: clear notification when app is killed from recent tasks. by @nur-shuvo in https://github.com/libre-tube/LibreTube/pull/6063
fix: crash when different threads access playing queue by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6083
fix: crash when refreshing channel page by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6120
fix: default value in behavior when minimized preference by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6118
fix: download activity not dismissed when dialog closed by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6054
fix: explicitely set status bar color after app start by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6080
fix: navigation bar color when pure theme disabled by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6029
fix: navigation bar missing nav items after closing player by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6122
fix: repeat current doesn't work if autoplay disabled by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6032
fix: search results scroll state not preserved when rotating by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6033
fix: use correct fragment manager for result callbacks by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6067
fix: use string resource for channel video tab by @FineFindus in https://github.com/libre-tube/LibreTube/pull/6065
fix: notification bell shown even though notifications disabled by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6133
chore: dont share with time code by default by @Bnyro in https://github.com/libre-tube/LibreTube/pull/6036

Pamilg8 commented 5 months ago

I can help😇

If you have not subscribed to the channel on the channel page, you cannot add it to the group.
If you return to the subscriptions section from the Home or Library page, the selected channel group is replaced by the default

https://github.com/libre-tube/LibreTube/assets/149590337/03fbd7fe-65a5-44e6-a737-18043901e978

videos do not open

gsdgethjfjj commented 5 months ago

Greetings!

Bottom bar is in wrong color when video is opened. For me it's color is correct when you open an app or comments but not the video itself. 1000013924

1000013921

1000013923

gsdgethjfjj commented 5 months ago

Colors in audio mode are different too.

1000013925

1000013926

1000013927

ScriptSlayer0 commented 5 months ago

https://github.com/libre-tube/LibreTube/assets/49728036/10826a6a-13cd-49c5-9b32-e046f4135b8f

I have experienced this error with the notification control, it only happens when I clicked on it to enlarge the window, as shown in the video. Once it is extended it is not possible to stop it in any way.

mizuhashikuniumi commented 5 months ago

Picture on picture bug java.lang.NullPointerException: null cannot be cast to non-null type com.github.libretube.ui.activities.MainActivity at com.github.libretube.ui.fragments.PlayerFragment.getMainActivity(PlayerFragment.kt:173) at com.github.libretube.ui.fragments.PlayerFragment.unsetFullscreen(PlayerFragment.kt:695) at com.github.libretube.ui.fragments.PlayerFragment$fullscreenDialog$2$1.onBackPressed(PlayerFragment.kt:182) at android.app.Dialog.onKeyUp(Dialog.java:673) at com.github.libretube.ui.fragments.PlayerFragment$fullscreenDialog$2$1.onKeyUp(PlayerFragment.kt:190) at android.view.KeyEvent.dispatch(KeyEvent.java:2866) at android.app.Dialog.dispatchKeyEvent(Dialog.java:826) at com.android.internal.policy.DecorView.dispatchKeyEvent(DecorView.java:390) at android.view.ViewRootImpl$ViewPostImeInputStage.processKeyEvent(ViewRootImpl.java:5953) at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:5821) at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5316) at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5373) at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5339) at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5491) at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5347) at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:5548) at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5320) at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5373) at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5339) at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5347) at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5320) at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5373) at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5339) at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5524) at android.view.ViewRootImpl$ImeInputStage.onFinishedInputEvent(ViewRootImpl.java:5682) at android.view.inputmethod.InputMethodManager$PendingEvent.run(InputMethodManager.java:3180) at android.view.inputmethod.InputMethodManager.invokeFinishedInputEventCallback(InputMethodManager.java:2722) at android.view.inputmethod.InputMethodManager.finishedInputEvent(InputMethodManager.java:2713) at android.view.inputmethod.InputMethodManager$ImeInputEventSender.onInputEventFinished(InputMethodManager.java:3157) at android.view.InputEventSender.dispatchInputEventFinished(InputEventSender.java:143) at android.os.MessageQueue.nativePollOnce(Native Method) at android.os.MessageQueue.next(MessageQueue.java:335) at android.os.Looper.loop(Looper.java:183) at android.app.ActivityThread.main(ActivityThread.java:7662) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

mizuhashikuniumi commented 5 months ago

https://github.com/libre-tube/LibreTube/assets/24605072/6a6acf3d-52fa-421a-a838-8e80dcb3c6ce

gloriouspuffy commented 5 months ago

Add the option to create a new channel group when a adding a channel to a group from channel's page

ScriptSlayer0 commented 5 months ago

On some channels I get -1 subscribers on the channel pages, I don't know if it's a bug or an instance problem, if someone can check or reproduce it. Because I'm not sure if it's just my phone or not.

Bnyro commented 5 months ago

On some channels I get -1 subscribers on the channel pages, I don't know if it's a bug or an instance problem, if someone can check or reproduce it. Because I'm not sure if it's just my phone or not.

It's a NewPipeExtractor issue, there's an open issue at the NewPipeExtractor repo for it.

ScriptSlayer0 commented 4 months ago

Screenshot_2024-06-21-05-11-35-93_7af1185115278aeb9699bfd161691b7e.jpg I don't understand why now appears this, it's the first time that I have seen it.😬😵‍💫

(I have already read this: https://github.com/TeamNewPipe/NewPipe/issues/11139), it happens to Libretube 🫤

tlden commented 4 months ago

You can't add to a channel group from the channel page if you have 10 or more channel groups. The 'ok' for confirmation is pushed off screen. At 9 channel groups the problem becomes noticeable.

Pamilg8 commented 4 months ago

Notification action buttons don't work in Android 12 either

https://github.com/libre-tube/LibreTube/assets/149590337/459486fc-581a-4f13-b3e3-9e8fcfc4827d

MatsG23 commented 4 months ago

Got this issue after playing multiple videos offline. The time line showed weird values.

java.lang.RuntimeException: Unable to destroy activity {com.github.libretube/com.github.libretube.ui.activities.OfflinePlayerActivity}: coil.network.HttpException: lateinit property mediaSession has not been initialized
    at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:5927)
    at android.app.ActivityThread.handleDestroyActivity(ActivityThread.java:5959)
    at android.app.servertransaction.DestroyActivityItem.execute(DestroyActivityItem.java:47)
    at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:60)
    at android.app.servertransaction.TransactionExecutor.executeLifecycleItem(TransactionExecutor.java:282)
    at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:150)
    at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:93)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2602)
    at android.os.Handler.dispatchMessage(Handler.java:107)
    at android.os.Looper.loopOnce(Looper.java:232)
    at android.os.Looper.loop(Looper.java:317)
    at android.app.ActivityThread.main(ActivityThread.java:8623)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
    at com.android.internal.os.ExecInit.main(ExecInit.java:50)
    at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
    at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:369)
Caused by: coil.network.HttpException: lateinit property mediaSession has not been initialized
    at com.github.libretube.util.NowPlayingNotification.destroySelf(SourceFile:78)
    at com.github.libretube.ui.activities.OfflinePlayerActivity.onDestroy(SourceFile:8)
    at android.app.Activity.performDestroy(Activity.java:9304)
    at android.app.Instrumentation.callActivityOnDestroy(Instrumentation.java:1566)
    at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:5914)
    ... 16 more

MatsG23 commented 4 months ago

I am experiencing app crashes playing videos in PiP for some time:

06-30 17:19:02.489  5703  5838 E MediaCodec: client does not own the buffer #2
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer: Video codec error
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:   android.media.MediaCodec$CodecException: client does not own the buffer #2
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:   
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at android.media.MediaCodec.releaseOutputBuffer(Native Method)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at android.media.MediaCodec.releaseOutputBufferInternal(MediaCodec.java:4125)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at android.media.MediaCodec.releaseOutputBuffer(MediaCodec.java:4046)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.mediacodec.AsynchronousMediaCodecAdapter.releaseOutputBuffer(AsynchronousMediaCodecAdapter.java:202)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.skipOutputBuffer(MediaCodecVideoRenderer.java:1528)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.processOutputBuffer(MediaCodecVideoRenderer.java:1330)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.drainOutputBuffer(MediaCodecRenderer.java:2010)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.render(MediaCodecRenderer.java:827)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.render(MediaCodecVideoRenderer.java:940)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.ExoPlayerImplInternal.doSomeWork(ExoPlayerImplInternal.java:1112)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:544)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at android.os.Handler.dispatchMessage(Handler.java:103)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at android.os.Looper.loopOnce(Looper.java:232)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at android.os.Looper.loop(Looper.java:317)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at android.os.HandlerThread.run(HandlerThread.java:85)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal: Playback error
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:   androidx.media3.exoplayer.ExoPlaybackException: MediaCodecVideoRenderer error, index=0, format=Format(5, null, null, video/avc, avc1.4D401F, 4370178, null, [854, 480, 60.0, ColorInfo(BT709, Limited range, SDR SMPTE 170M, false, 8bit Luma, 8bit Chroma)], [-1, -1]), format_supported=YES
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:623)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at android.os.Handler.dispatchMessage(Handler.java:103)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at android.os.Looper.loopOnce(Looper.java:232)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at android.os.Looper.loop(Looper.java:317)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at android.os.HandlerThread.run(HandlerThread.java:85)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:   Caused by: androidx.media3.exoplayer.video.MediaCodecVideoDecoderException: Decoder failed: c2.exynos.h264.decoder
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.createDecoderException(MediaCodecVideoRenderer.java:1915)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.render(MediaCodecRenderer.java:848)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.render(MediaCodecVideoRenderer.java:940)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.ExoPlayerImplInternal.doSomeWork(ExoPlayerImplInternal.java:1112)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:544)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       ... 4 more
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:   Caused by: android.media.MediaCodec$CodecException: client does not own the buffer #2
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:   
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at android.media.MediaCodec.releaseOutputBuffer(Native Method)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at android.media.MediaCodec.releaseOutputBufferInternal(MediaCodec.java:4125)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at android.media.MediaCodec.releaseOutputBuffer(MediaCodec.java:4046)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.mediacodec.AsynchronousMediaCodecAdapter.releaseOutputBuffer(AsynchronousMediaCodecAdapter.java:202)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.skipOutputBuffer(MediaCodecVideoRenderer.java:1528)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.processOutputBuffer(MediaCodecVideoRenderer.java:1330)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.drainOutputBuffer(MediaCodecRenderer.java:2010)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.render(MediaCodecRenderer.java:827)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       ... 7 more
06-30 17:19:02.533  5703  5838 D CCodecBufferChannel: [c2.exynos.h264.decoder#625] MediaCodec discarded an unknown buffer
06-30 17:19:02.533  5703  5838 D CCodecBufferChannel: [c2.exynos.h264.decoder#625] MediaCodec discarded an unknown buffer
06-30 17:19:02.534  5703  5807 D MediaCodec: keep callback message for reclaim
06-30 17:19:02.535  5703  5838 I CCodecConfig: query failed after returning 15 values (BAD_INDEX)
06-30 17:19:02.538  5703  5838 W Codec2Client: query -- param skipped: index = 1073743886.
06-30 17:19:02.538  5703  5838 W Codec2Client: query -- param skipped: index = 1610614798.
06-30 17:19:02.543  5703  5853 D CCodecBuffers: [c2.android.aac.decoder#377:1D-Output.Impl[N]] Client returned a buffer it does not own according to our record: 0
06-30 17:19:02.543  5703  5853 D CCodecBuffers: [c2.android.aac.decoder#377:1D-Output.Impl[N]] Client returned a buffer it does not own according to our record: 1
06-30 17:19:02.543  5703  5853 D CCodecBuffers: [c2.android.aac.decoder#377:1D-Output.Impl[N]] Client returned a buffer it does not own according to our record: 2
06-30 17:19:02.544  5703  5807 D MediaCodec: keep callback message for reclaim
06-30 17:19:02.544  5703  5853 I CCodecConfig: query failed after returning 20 values (BAD_INDEX)
06-30 17:19:02.545  5703  5853 W Codec2Client: query -- param skipped: index = 1342179345.
06-30 17:19:02.545  5703  5853 W Codec2Client: query -- param skipped: index = 2415921170.
06-30 17:19:02.545  5703  5853 W Codec2Client: query -- param skipped: index = 1610614798.
06-30 17:19:02.547  5703  5838 D SurfaceUtils: connecting to surface 0xb400db36372f9010, reason connectToSurface
06-30 17:19:02.547  5703  5838 I MediaCodec: [c2.exynos.h264.decoder] setting surface generation to 5839887
06-30 17:19:02.547  5703  5838 D SurfaceUtils: disconnecting from surface 0xb400db36372f9010, reason connectToSurface(reconnect)
06-30 17:19:02.547  5703  5838 D SurfaceUtils: connecting to surface 0xb400db36372f9000, reason connectToSurface(reconnect-with-listener)
06-30 17:19:02.548  5703  5838 D Codec2-OutputBufferQueue: C2SurfaceSyncMemory created 20(20)
06-30 17:19:02.548  5703  5838 D Codec2-OutputBufferQueue: remote graphic buffer migration 0/0
06-30 17:19:02.548  5703  5838 D Codec2Client: setOutputSurface -- failed to set consumer usage (6/BAD_INDEX)
06-30 17:19:02.548  5703  5838 D Codec2Client: setOutputSurface -- generation=5839887 consumer usage=0x900 sync
06-30 17:19:02.549  5703  5838 D Codec2Client: Surface configure completed
06-30 17:19:02.549  5703  5838 D SurfaceUtils: disconnecting from surface 0xb400db36373d7810, reason disconnectFromSurface
06-30 17:19:02.549  5703  5838 D CCodecBufferChannel: [c2.exynos.h264.decoder#625] MediaCodec discarded an unknown buffer
06-30 17:19:02.550  5703  5838 D CCodecBufferChannel: [c2.exynos.h264.decoder#625] MediaCodec discarded an unknown buffer
06-30 17:19:02.550  5703  5838 D CCodecBufferChannel: [c2.exynos.h264.decoder#625] MediaCodec discarded an unknown buffer
06-30 17:19:02.550  5703  5838 D CCodecBufferChannel: [c2.exynos.h264.decoder#625] MediaCodec discarded an unknown buffer
06-30 17:19:02.552  5703  5853 D CCodecBufferChannel: [c2.android.aac.decoder#377] MediaCodec discarded an unknown buffer
06-30 17:19:02.553  5703  5853 D CCodecBufferChannel: [c2.android.aac.decoder#377] MediaCodec discarded an unknown buffer
06-30 17:19:02.553  5703  5853 D CCodecBufferChannel: [c2.android.aac.decoder#377] MediaCodec discarded an unknown buffer
06-30 17:19:02.553  5703  5853 D CCodecBufferChannel: [c2.android.aac.decoder#377] MediaCodec discarded an unknown buffer
06-30 17:19:02.554  5703  5853 I hw-BpHwBinder: onLastStrongRef automatically unlinking death recipients
06-30 17:19:02.557  5703  5839 I hw-BpHwBinder: onLastStrongRef automatically unlinking death recipients
06-30 17:19:02.558  5703  5838 D SurfaceUtils: disconnecting from surface 0xb400db36372f9010, reason disconnectFromSurface
--------- switch to events
06-30 17:19:02.795  5703  5703 I wm_on_stop_called: [Token=127507263,Component Name=com.github.libretube.Default,Reason=LIFECYCLER_STOP_ACTIVITY,time=16ms]
--------- switch to main
06-30 17:19:03.004  5703  5703 I ExoPlayerImpl: Release 4081f9e [AndroidXMedia3/1.3.1] [bluejay, Pixel 6a, Google, 34] [media3.common, media3.ui, media3.exoplayer, media3.decoder, media3.exoplayer.hls, media3.datasource.cronet, media3.datasource, media3.extractor]
--------- switch to events
06-30 17:19:03.025  5703  5703 I wm_on_destroy_called: [Token=127507263,Component Name=com.github.libretube.Default,Reason=performDestroy,time=108ms]
--------- switch to main
06-30 17:19:03.026  5703  5703 W WindowOnBackDispatcher: sendCancelIfRunning: isInProgress=falsecallback=androidx.activity.OnBackPressedDispatcher$Api34Impl$createOnBackAnimationCallback$1@81ce9e9
06-30 17:19:03.057  5703  5703 E WindowManager: android.view.WindowLeaked: Activity com.github.libretube.ui.activities.MainActivity has leaked window com.android.internal.policy.DecorView{cc5dc43 V.E...... R....... 0,0-598,336 aid=1073741830}[Default] that was originally added here
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.view.ViewRootImpl.<init>(ViewRootImpl.java:1144)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.view.ViewRootImpl.<init>(ViewRootImpl.java:1130)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:427)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:158)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.app.Dialog.show(Dialog.java:352)
06-30 17:19:03.057  5703  5703 E WindowManager:     at com.github.libretube.ui.fragments.PlayerFragment.openOrCloseFullscreenDialog(PlayerFragment.kt:732)
06-30 17:19:03.057  5703  5703 E WindowManager:     at com.github.libretube.ui.fragments.PlayerFragment.onPictureInPictureModeChanged(PlayerFragment.kt:1480)
06-30 17:19:03.057  5703  5703 E WindowManager:     at androidx.fragment.app.Fragment.performPictureInPictureModeChanged(Fragment.java:3238)
06-30 17:19:03.057  5703  5703 E WindowManager:     at androidx.fragment.app.FragmentManager.dispatchPictureInPictureModeChanged(FragmentManager.java:3296)
06-30 17:19:03.057  5703  5703 E WindowManager:     at androidx.fragment.app.FragmentManager.lambda$new$3$androidx-fragment-app-FragmentManager(FragmentManager.java:623)
06-30 17:19:03.057  5703  5703 E WindowManager:     at androidx.fragment.app.FragmentManager$$ExternalSyntheticLambda3.accept(D8$$SyntheticClass:0)
06-30 17:19:03.057  5703  5703 E WindowManager:     at androidx.activity.ComponentActivity.onPictureInPictureModeChanged(ComponentActivity.java:1097)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.app.Activity.dispatchPictureInPictureModeChanged(Activity.java:9339)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.app.ActivityThread.handleWindowingModeChangeIfNeeded(ActivityThread.java:6581)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.app.ActivityThread.performActivityConfigurationChanged(ActivityThread.java:6368)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.app.ActivityThread.performConfigurationChangedForActivity(ActivityThread.java:6343)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.app.ActivityThread.handleActivityConfigurationChanged(ActivityThread.java:6779)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.app.ActivityThread.handleActivityConfigurationChanged(ActivityThread.java:6713)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.app.servertransaction.ActivityConfigurationChangeItem.execute(ActivityConfigurationChangeItem.java:58)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:60)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.app.servertransaction.TransactionExecutor.executeNonLifecycleItem(TransactionExecutor.java:231)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:152)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:93)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2602)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.os.Handler.dispatchMessage(Handler.java:107)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.os.Looper.loopOnce(Looper.java:232)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.os.Looper.loop(Looper.java:317)
06-30 17:19:03.057  5703  5703 E WindowManager:     at android.app.ActivityThread.main(ActivityThread.java:8623)
06-30 17:19:03.057  5703  5703 E WindowManager:     at java.lang.reflect.Method.invoke(Native Method)
06-30 17:19:03.057  5703  5703 E WindowManager:     at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
06-30 17:19:03.057  5703  5703 E WindowManager:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:894)

pokegamer5547 commented 4 months ago

Screenshot_20240702-082238_LibreTube Debug Sponsorblock submission screen by default enters current time as 00:00 format, but :symbol doesnt appear in number view of keyboard, thus we can't enter that symbol manually. Tested with AOSP keyboard too.

Bnyro commented 4 months ago

As said above,

report any regressions here

not issues that already existed in previous releases.

Bnyro commented 4 months ago

Thanks for the help everyone, I think we should do in the same way for the next releases :+1:

owosoup commented 4 months ago

The download support works flawlessly for Seal :) it opens a dialogue to choose whether I want to use a fast download (opens up dialogue on top of Libre tube and closes it after) or just open the app and download from there.

Bnyro commented 2 months ago

Fyi, there's no testing phase for the upcoming release due to the fact that it includes the fix for video playback everybody has been waiting for to make LibreTube usable again with public instances, the release after will get a normal testing phase again if everything goes as expected.

libre-tube / LibreTube