Closed Nancy-Chauhan closed 5 years ago
Hi @oleg-nenashev, yosys.sh script is specific to openrisc so I wanted it to be in the openRISC image folder and yes I can shift extract.stats.py to the main librecores-ci folder as it can be used globally.
I am not sure yosys.sh
should be in the image in the first place. Looks to be specific to a single project
yup
On Tue, Aug 13, 2019 at 5:36 PM Nancy Chauhan notifications@github.com wrote:
@Nancy-Chauhan commented on this pull request.
In librecores-ci-openrisc/test-scripts/yosys.sh https://github.com/librecores/docker-images/pull/28#discussion_r313467695 :
@@ -0,0 +1,7 @@ +#! /bin/bash + +cd /src + +fusesoc library add mor1kx /src
Yes it won't be applicable to other projects, but I did this according to discussions on PR openrisc/mor1kx#87 https://github.com/openrisc/mor1kx/pull/87 , should I move it in mor1kx repository ?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/librecores/docker-images/pull/28?email_source=notifications&email_token=AAW4RIG46DMCT52AL5NZGJLQELIGJA5CNFSM4ILEHGI2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCBNJWZA#discussion_r313467695, or mute the thread https://github.com/notifications/unsubscribe-auth/AAW4RIB3NO2OVPCA7HWFDD3QELIGJANCNFSM4ILEHGIQ .
@oleg-nenashev Changes Done! Regarding Documentation, I want to describe how we can make the use of extract-yosys-stats.py, which I can describe well once https://github.com/openrisc/mor1kx/pull/87 the pr is merged. I will add it later . Will it be fine ? Also I have assumed as per the sequence that new released version would be 0.4.0
The reason I asked the yosys.sh script to be added to the docker image is that the way it is written it only works when run from this docker image.
The mor1kx bit could be extracted to and env var as 'top_level'. The script is shared between mor1kx and or1k_marocchino.
If we want to keep it in mor1kx then it needs explaination,. Or keep it in a directory called ci/ or something.
I see you have updated the yosys.sh script in mor1kx. So this is good now. I still this could be made generic and stored in the image but that can be saved for later.
@oleg-nenashev I have added the documentation. Please let me know if changes required
From discussions at https://github.com/openrisc/mor1kx/pull/87
Adds scripts specifically used in Jenkins builds
CC @oleg-nenashev @stffrdhrn