Closed ghost closed 2 years ago
Would be great to integrate this so there is no need to install another add-on just for Piped (For the meantime, am using theirs: https://addons.mozilla.org/en-US/firefox/addon/piped-redirects/)
Yeah, I am also. The Thing is we can make them to can implement Invidious Redirect like there and just redirect to the Invidious Instance we want by just adding an Exception.
Instances list to be added : https://github.com/TeamPiped/Piped/wiki/Instances
Just remove the api
before implementing because it was to used to use between the Instances in the Own Pool of Instances
What api
do you mean?
The instances list is the weirdest list I've seen so far. I've eventually got all the URLs correct except for moomoo.me
.
I mean in the instances list remove api
from URL so it might not return a 404 error or a raw JSON data.
Is it separate from Invidious ?
Is it separate from Invidious ?
Ofc, you can choose between it and invidious in the settings pages
Will this be in a New Release or by hitting Update Instances ?
I think you can also consider this - https://github.com/SimonBrazell/privacy-redirect/issues/181#issuecomment-1019173916
Even redirecting invidious to Piped links if we want invidious links not to redirect we can use an Exception rule which will be useful. This is actually working of the Official Piped extension but there is not exception like in Lib or Privacy redirect.
Will this be in a New Release or by hitting Update Instances ?
Update instances only updates a json file containing a list of working insances. This new code should be in a new release.
I think you can also consider this - https://github.com/SimonBrazell/privacy-redirect/issues/181#issuecomment-1019173916 Even redirecting invidious to Piped links if we want invidious links not to redirect we can use an Exception rule which will be useful. This is actually working of the Official Piped extension but there is not exception like in Lib or Privacy redirect.
Why do you want to redirect invidious links?
I think you can also consider this - SimonBrazell#181 (comment) Even redirecting invidious to Piped links if we want invidious links not to redirect we can use an Exception rule which will be useful. This is actually working of the Official Piped extension but there is not exception like in Lib or Privacy redirect.
Why do you want to redirect invidious links?
Because Piped is better than Invidious in terms of overall Use, Performance and Stability and unlike Slow development of Invidious it is developing at a faster rate and the community like it.
That is also why I told you that if we need Invidious we can make a exception. If you are worried that other users will not know better make a notice about it when using the feature.
I mean the only links that the user will click are youtube links, I didn't see any invidious link other than in matrix rooms
I already made Piped the default option, users can however choose the frontend they want:
Same thing goes for Translate, Search, Reddit. All have multiple frontends that you can choose which one in the settings. However, the best option is the default option.
I think you should use the Official Piped Redirects extension, enable it and then click on Invidious and YouTube Links with Libredirect disabled.
You will then understand by what I mean
I've now done that, yeah redirecting Invidious links to Piped, but why? No one uses invidious links to share media.
Maybe I'm missing something?
Maybe I'm missing something?
Because privacy oriented guys like Techlore in their surveillance Report and majority of matrix users use Invidious links of Instead of YouTube which is very much old schooled and broken often at sometimes so you don't get to like to view it and also in Piped we have an account system like Piped and settings that apply cross site. But in Invidious we need to have the settings already and need to save it as a cookie and also we may clear and many consequences to face with Invidious such as Google Captchas & limits number of users or Video Player Broke, etc.
That is why I also propose a solution add a banner in the section and use of exception solves this.
I see, I'll make it when invidious
is selected, it will forward youtube
and piped
urls to it. Same thing for piped
, it will redirect youtube
and invidious
links to it. Same for FreeTube too...
That is why I also propose a solution add a banner in the section and use of exception solves this.
If a person chose to view videos in a specific Frontend, then I don't think they want to have exceptions. If someone requested that feature, I'll add it.
What do you think @Loki-L1130 ?
@ManeraKai I think this is pretty much a great Idea to implement. Both Invidious and Piped users gets benefit of this.
With the exceptions, You don't need to do anything as in the exceptions menu of Libredirect, If we add a URL it is automatically excluded from redirection. That's it. You just need to force the URLs to redirect to specific Frontends.
This is personal Question, How to actually use the Freetube Redirect because I haven't used it from the start ?
Does the settings you have for Invidious do apply to Piped too ?
Does the settings you have for Invidious do apply to Piped too ?
No, I don't think Piped have this options. CC: @FireMasterK
This is personal Question, How to actually use the Freetube Redirect because I haven't used it from the start ?
Just install FreeTube, and select it as a frontend, this is how it redirects in code: https://github.com/libredirect/libredirect/blob/master/src/assets/javascripts/helpers/youtube/youtube.js#L239
original: https://www.youtube.com/watch?v=J4osVFVeQrI
new: freetube://https://www.youtube.com/watch?v=J4osVFVeQrI
Does the settings you have for Invidious do apply to Piped too ?
Not yet, but that is a nice idea btw.
No, I don't think Piped have this options. CC: @FireMasterK
A full list of parameters can be found at https://piped-docs.kavin.rocks/docs/parameters/
original:
https://www.youtube.com/watch?v=J4osVFVeQrI
new:freetube://https://www.youtube.com/watch?v=J4osVFVeQrI
So, It automatically opens Videos in Freetube even it is an embed ?
Not yet, but that is a nice idea btw.
@FireMasterK Could help you ya ?
So, It automatically opens Videos in Freetube even it is an embed ?
This might be a problem. I thought of it before to add an extra option for embeds if FreeTube was selected.
I forgot I added the disable freetube part for only embeds. Now I just need to add an additional setting.
So, It automatically opens Videos in Freetube even it is an embed ?
This might be a problem. I thought of it before to add an extra option for embeds if FreeTube was selected.
I am just asking not a feature request.
I am just asking not a feature request.
It became a feature request, no problems with that 👍
Kai, Can you also look onto this ?
https://github.com/TeamPiped/Piped-Redirects/issues/10#issue-1030091296
2nd Video. Can you be able to fix it ?
@FireMasterK can you also contribute something for this ?
Consider this : https://github.com/TeamPiped/Piped/issues/786#issuecomment-1030610237 before full implementation of Piped. I mean hang on.
Isn't the extension considered as the full implementation?
Isn't the extension considered as the full implementation?
Yeah, It is but it has issues with replacing embeds of Shorts Videos alone. Which I think could be fixed as Invidious does this perfectly. May consider this as you could be able to fix this.
in invidious redirection: just delete of the /shorts
path
https://github.com/libredirect/libredirect/blob/master/src/assets/javascripts/helpers/youtube/youtube.js#L268
So, You mean it is possible on Piped like you did for Invidious or does @FireMasterK do need to change anything on the Frontend side ?
Youtube shorts are just like regular videos.
do need to change anything on the Frontend side ?
No need, hopefully
So, You made the shorts video to be like a normal Video - Right ?
yep
Great, Then, I think everything is solved and Piped is Ready for Deployment.
Just test it first if you can.
Sure, But How ?
Does the settings you have for Invidious do apply to Piped too ?
Maybe this is pending.
Piped is Privacy-oriented YouTube Frontend which is like Invidious but uses Javascript. I think you can add it as a Separate option instead of mixing in the Invidious Instance Pool.
Open Issue in Main repo : https://github.com/SimonBrazell/privacy-redirect/issues/181