libredirect / browser_extension

A browser extension that redirects popular sites to alternative privacy friendly frontends
https://libredirect.github.io
GNU General Public License v3.0
3.27k stars 121 forks source link

Add redirections for Hackernews #239

Closed ghost closed 2 years ago

ghost commented 2 years ago

Hackernews is a social news network. There are two libre front-ends available for it which would be nice to have:

IkelAtomig commented 2 years ago

It's great to know, But What does it add to Privacy Can you list that ?

m77e4t commented 2 years ago

Libredirect (fork of Privacy redirect) is an Privacy enhancing software. Unless and until the redirection does not offer any privacy benefit I don't think we should offer any redirection. If not then then Libredirect will have to offer 100's of redirection for no reason.

Hacker news [news.ycombinator.com] itself is not privacy harming in any way.

ManeraKai commented 2 years ago

LibRedirect main goal is to redirect to multiple random decentralized privacy friendly instances. I'll treat those two like how I treated Qwant, Mojek, and Startpage, if someone wants them to be redirected, then make a separate extension for them: Qwant, Mojek, Startpage

I think I'll also do the same with old.reddit.com as there's already an extension with over 32,000 users for it.

I think I'll also remove pixiv.moe as there's only one instance and it's not that privacy friendly. it even now requires a login and you can't browse anything without logging in. ex: https://pixiv.moe https://pixiv.moe/illust/96572356

I don't want to bloat the extension. I'll just add those who are privacy friendly or who are the best but not the perfect option for privacy that's available right now.

ghost commented 2 years ago

It's great to know, But What does it add to Privacy Can you list that ?

Libredirect (fork of Privacy redirect) is an Privacy enhancing software. Unless and until the redirection does not offer any privacy benefit I don't think we should offer any redirection. If not then then Libredirect will have to offer 100's of redirection for no reason.

Hacker news [news.ycombinator.com] itself is not privacy harming in any way.

Compared to Hacker News the projects are open source that is the main privacy advantage they have.

LibRedirect main goal is to redirect to multiple random decentralized privacy friendly instances. I'll treat those two like how I treated Qwant, Mojek, and Startpage, if someone wants them to be redirected, then make a separate extension for them: Qwant, Mojek, Startpage

I think I'll also do the same with old.reddit.com as there's already an extension with over 32,000 users for it.

I think I'll also remove pixiv.moe as there's only one instance and it's not that privacy friendly. it even now requires a login and you can't browse anything without logging in. ex: https://pixiv.moe https://pixiv.moe/illust/96572356

I don't want to bloat the extension. I'll just add those who are privacy friendly or who are the best but not the perfect option for privacy that's available right now.

I understand, the privacy advantage might not be as big as other projects and I would understand not using this redirection. You also mentioned about thinking of removing pixiv.moe. I think removing Firefox Send would also make sense. Because there rarely is a case where you will get redirected and it adds uneccesary bloat.

ManeraKai commented 2 years ago

I think removing Firefox Send would also make sense. Because there rarely is a case where you will get redirected and it adds uneccesary bloat.

Problem with Send is that it's really hard to find and I want to distribute the load between instances. getting redirected is really hard so that's why I added links to the popup. Press on any service/frontend in the popup and you'll get redirected right away to a random instance.

Thinking also of LibreSpeed too as it only has one instance and I'm just redirecting the root path / and nothing else useful.

cc: @sonalder-darlene

vairag22 commented 2 years ago

Then Send should be a button like 🔃 Instance, Settings and Copy Raw in the Popup Menu.

ManeraKai commented 2 years ago

it's already like this. Just go the general settings tab an enable it to be shown. Maybe I should show it by default. image

vairag22 commented 2 years ago

Nope. It's a toggle button, not a "button" button like Settings or Copy Raw.

image

ManeraKai commented 2 years ago

will just be out of context. It's a Frontend not a function. all the other frontend buttons have the same functionality.

vairag22 commented 2 years ago

Firefox Send (send.firefox.com) has been discontinued. LR does not redirect from that website.

ManeraKai commented 2 years ago

https://github.com/timvisee/send

You won't find it easily as the keyword "send" is really common.

vairag22 commented 2 years ago

Okay I checked sendTargets.js.

const targets = [ /^https?:\/{2}send.invalid\/$/, /^ https ?: \/\/send\.firefox\.com\/$/, /^https?:\/{2}sendfiles\.online\/$/ ];

It only redirects from https://send.invalid and https://sendfiles.online, not https://send.firefox.com.

vairag22 commented 2 years ago

will just be out of context. It's a Frontend not a function. all the other frontend buttons have the same functionality.

I didn't knew about sendfiles.online.

ManeraKai commented 2 years ago

I'll try to add more links for redirecting off of them for Send.

ManeraKai commented 2 years ago

Like hn-search is just a search engine for hackernews. It doesn't need automated redirections.

vairag22 commented 2 years ago

Is this issue still relevant?

ManeraKai commented 2 years ago

Yes, The only thing I don't like is it having one instance. Though osm, an facilmap are the same story and I have a custom instance option in the settings for facilmap.

vairag22 commented 2 years ago

Yes, The only thing I don't like is it having one instance.

What 😕?

Didn't you reject adding redirects for Hackernews because it isn't a risk to user privacy, then we shifted the topic to a bug in Send redirects: send.firefox.com is not redirected to where it should instead it redirects to mozilla.org even though everything seems fine in the regex.

const targets = [ /^https?:\/{2}send.invalid\/$/, /^ https ?: \/\/send\.firefox\.com\/$/, /^https?:\/{2}sendfiles\.online\/$/ ];

You said you'll fix this and add new links to Send, if possible.

Is this issue still relevant?

I meant, have you fixed the bug we discussed earlier?

ManeraKai commented 2 years ago

After seeing the source code of the homepage of hacker news, yes I won't add this frontend. This frontend (https://github.com/rajatkulkarni95/hckrnws) even states that it's for a better reading experience rather than a privacy this. And you are correct @vairag22, there's nothing wrong in the homepage of hacker news.