search

libredirect / browser_extension

A browser extension that redirects popular sites to alternative privacy friendly frontends
https://libredirect.github.io
GNU General Public License v3.0
3.23k stars 119 forks source link

Redirecting to down instances #557

Closed DogCatPuppyLover closed 1 year ago

DogCatPuppyLover commented 1 year ago

I was told to bring this here, as it seems to be an issue with LibRedirect: https://github.com/TeamPiped/Piped/issues/1828

It's also strange how, when using piped.kavin.rocks, the requests are getting redirected to pipedapi.moomoo.me.

Cwpute commented 1 year ago

It may be an instance or front-end based feature. Either way, i'm pretty sure it doesn't depend on LibRedirect :)

FireMasterK commented 1 year ago

It may be an instance or front-end based feature. Either way, i'm pretty sure it doesn't depend on LibRedirect :)

Changing the backend is indeed a front-end feature.

Looking at https://github.com/libredirect/libredirect/blob/4625aa07feb647ecbaa9a2316e778a7bcc01c605/src/assets/javascripts/services.js#L576-L580 I think that this may not be entirely true. However, I'm not sure where/how libreddit sets preferences. This can be used to override the backend used.

DogCatPuppyLover commented 1 year ago

I think that the problem is that LibRedirect is syncing the "Instance" preference across instances when you select "Unify Settings", which should be unique to each instance. So, when the instance you unified from goes down, it appears to affect all instances.

IkelAtomig commented 1 year ago

The last comment is exactly right. But closing this as we are going to remove support for Unify Settings in Next release.