libredirect / browser_extension

A browser extension that redirects popular sites to alternative privacy friendly frontends
https://libredirect.github.io
GNU General Public License v3.0
3.17k stars 118 forks source link

Additions to Next release - v2.8.0 #768

Closed IkelAtomig closed 1 year ago

IkelAtomig commented 1 year ago

P.S. Things that I noticed in my Radar are listed here. Other open issues will be looked and could be added.

Comments are welcome regarding the features don't like. But open a new issue and reference this one there. To keep it tidy.

ManeraKai commented 1 year ago

Stick to the default variable when switching frontends for Redirect type in YouTube. Instead of being separate

This is already like that?

ManeraKai commented 1 year ago

Hide Unsupported iframes handling option for frontends that don't support it.

This option IS for the urls that the frontends don't support.

IkelAtomig commented 1 year ago

Then rename it as URLs when we don't replace embeds for a frontend.

ManeraKai commented 1 year ago

You still didn't understand it, it was before Unsupported urls handling, but we changed it to Unsupported iframes handling bc it is only for iframes. Say Piped-Material doesn't support iframes, so we need an option to tell LibRedirect to either bypass any youtube iframe or block it entirely, hence Unsupported iframes handling exists.

IkelAtomig commented 1 year ago

Just keep it as iframes handling for YouTube, Twitter and rename as URLs for other frontends. I guess that would make sense and avoid confusion.

ManeraKai commented 1 year ago

for other frontends they may have iframes too, and the option doesn't do anything other than iframes my man.

IkelAtomig commented 1 year ago

Well, it could be reused then. For example, IMDb frontend still doesn't support few URLs such as Movie company info - https://imdb.com/company/co0485456?ref_=tt_dt_co_1. For these, when we set it to bypass, it loads IMdb or loads libremdb when set to block. That is how it should function.

If renamed as unsupported URLs handling. But in the case of iframes, only YouTube, Twitter, Imgur, Reddit and possibly, Bandcamp has iframes. So, either hide it for other frontends or rename it.

ManeraKai commented 1 year ago

https://github.com/libredirect/browser_extension/issues/648