libredirect / browser_extension

A browser extension that redirects popular sites to alternative privacy friendly frontends
https://libredirect.github.io
GNU General Public License v3.0
3.29k stars 122 forks source link

[Bug] Unrecognized manifest key 'browser_specific_settings'. #921

Closed 825i closed 6 months ago

825i commented 6 months ago

Screenshot 2024-05-07 092802

Extension Version: 2.8.4 Browser: Brave Browser 1.65.126 OS: Windows 11

Code block:

"browser_specific_settings": {
        "gecko": {
            "id": "7esoorv3@alefvanoon.anonaddy.me",
            "strict_min_version": "89.0"
        },
        "gecko_android": {
            "strict_min_version": "113.0"
        }
    },
825i commented 6 months ago

This seems to be a Manifest v3 error, as this key isn't supported in v2 which the extension is using. As generally every browser will now support v3, if this block of code really isn't needed, it should be removed as it seems to trigger across multiple browsers (Chrome, Chromium, Firefox and Brave) and doesn't actually seem to do anything except throw this error. I can't see any reason to include this as v2 doesn't support these options and if we are using v2, this block will do nothing except throw an error.

If "some" browsers require this and its worthwhile leaving in, then those which throw the error (the above listed) should have a separate build for an extension without this block.

EDIT: I removed the above code block and the error disappeared. I realise I could probably just leave it, but as it is incompatible with my browser and does nothing except throw a persistent error. I removed it without any negative consequences.

Thanks for the extension btw, it's awesome and for the crazy effort you've made in closing 700+ issues. I wish it was on the Chrome store.

IkelAtomig commented 6 months ago

It was meant to determine minimum browser version for the extension to run on Firefox based browsers. This errors pops out only during developer mode in chrome.

It doesn't affect anything in Chromium based browser. It just shows because the key is not defined in their manifest documentation of Chromium and only meant for firefox. Nothing much

Regarding chrome Web Store : http://libredirect.github.io/faq.html#chrome_web_store