search

libredirect / browser_extension

A browser extension that redirects popular sites to alternative privacy friendly frontends
https://libredirect.github.io
GNU General Public License v3.0
3.29k stars 122 forks source link

ability to disable the Error message window through a toggle ? #992

Closed YAKSL closed 2 months ago

YAKSL commented 2 months ago

the current behavior of the error window is it's opening in the current tab even when i'm on a website that's not related to any redirect rule, also when the redirect website functions correctly but the fact that libredirect detects that it gave some error the error window still opens which is kinda annoying. the error message should at least open in a new window not redirect to it to begin with

Snapshot

YAKSL commented 2 months ago

the only fix for this is to use the previous version (2.9.1) for now

ManeraKai commented 2 months ago

What happens when you press Switch Instance?

And show me a URL and your settings. I'm not able to reproduce it.

nc7s commented 2 months ago

Happens here too. It goes into this screen for any failed request, which in my case includes mqdefault.jpg and favicon.ico. I think this is a nice feature, but it's bizarre to see the switch went to some placeholder image.

nc7s commented 2 months ago

And it still goes to this error page even if I disabled the specific redirect (in this case Youtube for an Invidious instance).

smaragdus commented 2 months ago

Version 3.0.0 makes LibRedirect totally unusable on Firefox mobile as one cannot downgrade to the last good version (2.9.1) and one cannot prevent the extension to update to the latest faulty version (3.0.0) either. One must be really quick to copy the redirect link before the error message appears and paste it into another browser. This happens with one Nitter instance which appears to be performing some stupid browser check. So currently I am forced to go to my old practice of copying original links and manually editing them in a text editor. I think that LibRedirect should just redirect links according to user's choices, not spewing some false error messages. The most important principle in software development is "If it works, don't fix it!".

YAKSL commented 2 months ago

What happens when you press Switch Instance?

And show me a URL and your settings. I'm not able to reproduce it.

it happens with this one https://youtube.com/watch?v=kIVdN9rG748 on https://inv.nadeko.net as the instance (HD720 quality), and on other videos/instances too. i haven't tested it on other frontends before downgrading

ManeraKai commented 2 months ago

I think having those buttons in the popup will be better.

ManeraKai commented 2 months ago

Version 3.0.0 makes LibRedirect totally unusable on Firefox mobile as one cannot downgrade to the last good version (2.9.1) and one cannot prevent the extension to update to the latest faulty version (3.0.0) either.

I will remove the listener for the server errors as a hotfix. Later, I will migrate the buttons to the popup.

ManeraKai commented 2 months ago

If you have a single instance: image If you have multiple instances: image