search

libredirect / browser_extension

A browser extension that redirects popular sites to alternative privacy friendly frontends
https://libredirect.github.io
GNU General Public License v3.0
3.29k stars 122 forks source link

extra slash forced on custom instances #996

Closed iamwacko closed 2 months ago

iamwacko commented 2 months ago

on Firefox, libredirect 3.0.0

I added a custom invidious instance, and was trying to use it, when I noticed that I kept getting redirected to the homepage. I did a little digging with inspect, and it seems that I was getting a 302 because of the double slashes. The non-custom instances don't have that slash. I didn't find anything about similar issues in the issue trackers, and custom instances I added previously didn't have the extra slash.

Reproduction steps:

  1. Go to libredirect Youtube settings, copy one of the default instances, paste it into the "custom" box, and hit plus
  2. Remove any other favorite, so it has to use the custom instance
  3. Go to https://www.youtube.com/youtube, and witness how it won't go to YouTube's channel, but instead the homepage (you can also try with any other channel or video link)
cameronj86 commented 2 months ago

Samesies.

Ironically I experienced the same thing just now and was about to load a tix. All of my existing custom instances are unaffected but I can't add anything new without it erroring out

AresUII commented 2 months ago

Not properly fixed as of 3.0.1. See #999.

iamwacko commented 2 months ago

Not properly fixed as of 3.0.1. See #999.

The fix was committed after 3.0.1 was released, so that's not surprising