search

libreform / wp-libre-form

Easy native HTML5 forms for WordPress. Version 1.5 is unmaintained, but works without issue. 2.0 has been rewritten from the ground, and can be found at https://github.com/libreform/libreform
https://wordpress.org/plugins/wp-libre-form
GNU General Public License v3.0
67 stars 27 forks source link

$headers -variable declared as array but treated as string. #166

Closed ironland closed 5 years ago

ironland commented 5 years ago

Merging two separate fix PRs #146 and #144 has caused the same issue as described in #129 but the other way around. Now the $headers -variable is declared as an array but treated as a string inside the next conditional clause.

https://github.com/libreform/wp-libre-form/blob/master/inc/wplf-form-actions.php#L53

k1sul1 commented 5 years ago

I don't know why we haven't fixed this earlier (guess it hasn't given me any issues, but that might be because I very rarely use the email), but I just pushed a commit that fixes this.

I didn't fix it straight at master because #167 will introduce so many changes that I'd rather not have any unnecessary conflicts as fixing them is very error prone.

I might've broken production a couple of times with a conflict resolution that looked correct but wasn't.