search

librehat / com.librehat.yahooweather

[DEPRECATED] Yahoo! Weather Widget for Plasma Desktop
https://www.kde-look.org/p/998912/
GNU General Public License v3.0
23 stars 11 forks source link

Re: #41: Change forecast lo~hi to row of hi above row of lo. #52

Closed smitgd closed 8 years ago

smitgd commented 8 years ago

Change ForecastDelegate.qml from "Column" to "Item" so each element can be independently positioned. This avoids too large spacing between the row of High forecast temperatures and the row of Lows. This also changes the "temp" string in Forecast.qml list model to two separate strings "tempHi" and "tempLo" that are placed on their own row on the widget (instead of on same row separted by a tilde).

librehat commented 8 years ago

Please don't change Column, anchors, spacing... We should let them be independent rows. It's OK to be spaced just like other rows.

smitgd commented 8 years ago

Just my opinion but to me it looks odd to have the row of high temps and the row of low temps spaced far apart. They should be spaced the same distance as the "Sunrise" and "Sunset" and other items near the top are spaced. Using the "Column" object type, the items in the column are all spaced "units.gridUnits" apart, or whaterver spacing is set to (even 0, which still results in too wide spacing on high and low temps).