Closed carlosmiranda closed 9 years ago
@carlosmiranda Thanks, I will find someone to review this PR soon
@krzyk do this review
@carlosmiranda please see my comments above
@krzyk Revised as per your comments, please have another look.
@rultor merge pls
@rultor merge pls
@krzyk Thanks for your request. @yegor256 Please confirm this.
@rultor try to merge
@rultor try to merge
@yegor256 OK, I'll try to merge now. You can check the progress of the merge here
@rultor try to merge
@yegor256 Done! FYI, the full log is here (took me 6min)
@rultor deploy please
@rultor deploy please
@carlosmiranda Thanks for your request. @yegor256 Please confirm this.
@rultor deploy
@rultor deploy
@yegor256 OK, I'll try to deploy now. You can check the progress here
@rultor deploy
@yegor256 Done! FYI, the full log is here (took me 7min)
@krzyk I added 17 mins to your account, many thanks for working with the project! The completion time here was 58042797.. you're getting extra minutes here (c=2). +17 added to your rating, current score is: +4675
@rultor deploy pls
278:
visible
flag inMkAttributes
is now based on custom metadataMkAttributesTest.setVisibility()
revised slightly, the file had to exist before the metadata can be set. Otherwise, it will throw anIOException
.TkSetVisibilityTest.setsVisibility()
revised heavily and enabled.