search

libreio / libre

Simple AWS gateway for storing and sharing files
http://libre.io
Other
7 stars 9 forks source link

#274 fix NPE #294

Closed dmzaytsev closed 9 years ago

dmzaytsev commented 9 years ago

@rultor merge

rultor commented 9 years ago

@rultor merge

@dmzaytsev Thanks for your request. @yegor256 Please confirm this.

k0r commented 9 years ago

@dmzaytsev Travis CI error.

dmzaytsev commented 9 years ago

@k0r just not complete

yegor256 commented 9 years ago

@k0r it's a very bad practice to merge directly into master without Rultor. please, stop doing this

dmzaytsev commented 9 years ago

@yegor256 I did push one more commit but I can't see it

karato commented 9 years ago

@dmzaytsev Thanks for the pull request, let me find a reviewer..

dmzaytsev commented 9 years ago

@yegor256 this https://github.com/dmzaytsev/nerodesk/commit/7ae008399784dfcab6553c4c9dd783c3e63c9959

yegor256 commented 9 years ago

@dmzaytsev that's because @k0r merged your branch already into master, without rultor and code review :(

dmzaytsev commented 9 years ago

@yegor256 any idea how to fix it ?

karato commented 9 years ago

@krzyk review it

dmzaytsev commented 9 years ago

@yegor256 maybe create a new branch ?

dmzaytsev commented 9 years ago

@yegor256 anyway we can release now NPE should be disappear but date will be empty

yegor256 commented 9 years ago

@dmzaytsev yes, they only solution is to create a new branch and a new pull request

dmzaytsev commented 9 years ago

I create new PR #295

karato commented 9 years ago

@krzyk I don't see any messages from you above, not sure if there was actual contribution (correct me if I'm wrong)

karato commented 9 years ago

@rultor deploy pls

rultor commented 9 years ago

@rultor deploy pls

@karato OK, I'll try to deploy now. You can check the progress here

rultor commented 9 years ago

@rultor deploy pls

@karato Oops, I failed. You can see the full log here (spent 6min)


Tests in error: 
  TkAppTest.launchesWebServerInNonLatinLocale:130 ? IllegalArgument Doesn't look...
  TkAppTest.launchesOnRandomPort:97 ? IllegalArgument Doesn't look like XML: 'oo...
  TkDocsTest.addsDocumentLinksInHTML:151 ? IO javax.xml.transform.TransformerCon...
  TkDocsTest.formatsDate:198 ? IO javax.xml.transform.TransformerConfigurationEx...
  TkDocsTest.addsShortLinkInHTML:118 ? IO javax.xml.transform.TransformerConfigu...

Tests run: 81, Failures: 0, Errors: 5, Skipped: 4

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:32 min
[INFO] Finished at: 2015-05-29T22:38:41+00:00
[INFO] Final Memory: 53M/476M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project nerodesk: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/r/repo/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project nerodesk: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
    at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:82)
    at org.apache.maven.plugin.surefire.SurefirePlugin.handleSummary(SurefirePlugin.java:195)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:861)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:729)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 19 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException